Merge pull request #6616 from certik/volatile_warning

Add a warning that volatile attribute is not supported yet

Author: certik

Dockerfile

@@ -11,7 +11,7 @@ RUN bash Miniforge3-$(uname)-$(uname -m).sh -b
 
 RUN /root/miniforge3/bin/mamba init bash
 
-WORKDIR /lfortran
+WORKDIR /lfortran_build
 
 COPY . .
 
@@ -29,4 +29,4 @@ FROM ubuntu:22.04 AS app
 RUN apt update
 RUN apt install binutils clang --no-install-recommends -y
 
-COPY --from=build /lfortran/inst /app
+COPY --from=build /lfortran_build/inst /app

src/lfortran/semantics/ast_common_visitor.h

@@ -3373,6 +3373,11 @@ class CommonVisitor : public AST::BaseVisitor<Derived> {
                                 ::AttrNoPass) {
                             } else if (sa->m_attr == AST::simple_attributeType::AttrVolatile) {
                                 // TODO: Implement volatile attribute
+                                diag.add(Diagnostic(
+                                    "The volatile attribute is not implemented yet (https://github.com/lfortran/lfortran/issues/6555), ignoring for now",
+                                    Level::Warning, Stage::Semantic, {
+                                        Label("",{sa->base.base.loc})
+                                }));
                             } else {
                                 diag.add(Diagnostic(
                                     "Attribute type not implemented yet " + std::to_string(sa->m_attr),

tests/errors/continue_compilation_1.f90

@@ -68,7 +68,7 @@ program continue_compilation_1
     integer, parameter :: zero = 0
     integer :: x = 1
     real :: adwf = .true.
-
+    integer, volatile :: volatile_var
 
 
 

tests/reference/asr-continue_compilation_1-04b6d40.json

@@ -2,12 +2,12 @@
     "basename": "asr-continue_compilation_1-04b6d40",
     "cmd": "lfortran --semantics-only --continue-compilation --no-color {infile}",
     "infile": "tests/errors/continue_compilation_1.f90",
-    "infile_hash": "f61ceeb18d5c0691a20bb0c80b78a2dd5737ee3a1f6c6767593d45b4",
+    "infile_hash": "b0a44f6ea3539170c3a63a3091ed8c7ed50db83056d8124c17a17330",
     "outfile": null,
     "outfile_hash": null,
     "stdout": null,
     "stdout_hash": null,
     "stderr": "asr-continue_compilation_1-04b6d40.stderr",
-    "stderr_hash": "46d28064e27ef07141fb6aa7ff96f7fd6194a8e134bde0eeef71f8a3",
+    "stderr_hash": "1e77cc565426f0ab9944ce60e24316e72b0beb2b16344b6f83eb0f8d",
     "returncode": 1
 }

tests/reference/asr-continue_compilation_1-04b6d40.stderr

@@ -20,6 +20,12 @@ semantic error: Cannot convert LOGICAL to REAL
 70 |     real :: adwf = .true.
    |                    ^^^^^^ 
 
+warning: The volatile attribute is not implemented yet (https://github.com/lfortran/lfortran/issues/6555), ignoring for now
+  --> tests/errors/continue_compilation_1.f90:71:14
+   |
+71 |     integer, volatile :: volatile_var
+   |              ^^^^^^^^ 
+
 semantic error: Assignment to loop variable `i` is not allowed
    --> tests/errors/continue_compilation_1.f90:114:8
     |