Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different translation tables #57

Closed
giacomomutti opened this issue Mar 1, 2024 · 7 comments
Closed

Different translation tables #57

giacomomutti opened this issue Mar 1, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@giacomomutti
Copy link

Hello!
I was wondering if it would be possible to add a feature to miniprot to use different non-standard genetic codes to use during the translation of the reference genome step. It would be extremely useful to annotate genes in certain lineages

Thank you very much for the amazing tool!

lh3 added a commit that referenced this issue Mar 6, 2024
@lh3 lh3 added the enhancement New feature or request label Mar 6, 2024
@lh3
Copy link
Owner

lh3 commented Mar 6, 2024

The github HEAD now supports NCBI translation table 1 through 5. If you need rarer tables, let me know.

@lh3 lh3 closed this as completed Mar 6, 2024
@giacomomutti
Copy link
Author

giacomomutti commented Mar 6, 2024

Thank you very much for the quick implemenation!

I would need rarer tables as I am studying ciliates genome (for example, tables 27, 29 and 30). I transformed all ncbi genetic tables in the format used in nasw-tab.c (AAA,AAC... order) in case it may be useful (
genetic_tables.txt
). However, some indexes are not present (like 7, 8, 17 to 20) and I guessed this would need to be handled in the code somehow but I don't know how to program in C to do a pull request. I hope this is useful and thanks again!

lh3 added a commit that referenced this issue Mar 6, 2024
@lh3
Copy link
Owner

lh3 commented Mar 6, 2024

Added. Thank you so much!

@giacomomutti
Copy link
Author

Wow, thank you so much again for the speed. However there is one slight issue. If you use -T 6 it says "[ERROR] failed to find translation table 6" but it should be there. The same happens for -T 33. I guess there is a problem with indexing (it seems that to use table 6 you need to input -T 5). Indeed if you run -T 8 (which should return error), it works, I guess using table 9.

@lh3
Copy link
Owner

lh3 commented Mar 6, 2024

That is a bug. Now fixed. Thanks!

@george-coulouris
Copy link

george-coulouris commented May 23, 2024

Hi @lh3!

Can you add support for translation table 25?

Thanks!

@lh3
Copy link
Owner

lh3 commented May 23, 2024

it should be there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants