Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaks configuration #869

Closed
Therzok opened this issue Nov 13, 2014 · 6 comments
Closed

Leaks configuration #869

Therzok opened this issue Nov 13, 2014 · 6 comments

Comments

@Therzok
Copy link
Member

Therzok commented Nov 13, 2014

Any reason for having this?

@nulltoken
Copy link
Member

See SafeHandleBase.

A warning is issued when we forgot to explicitly release a handle. The configuration allows to activate the StackTrace and find out where the handle was initially "allocated".

@Therzok
Copy link
Member Author

Therzok commented Nov 13, 2014

Well, can't we just define a LEAKS symbol in Debug/Release whenever we want to? I see no need for an extra configuration.

@nulltoken
Copy link
Member

👍

Would you fancy a PR? 😉

@Therzok
Copy link
Member Author

Therzok commented Nov 13, 2014

Sir, will do, sir!

@Therzok
Copy link
Member Author

Therzok commented Nov 13, 2014

Here's the deal: I'll make a PR which fixes 3 issues or 3 PRs which fix these issues in the following order:

@nulltoken
Copy link
Member

I think having 3 separated PRs would be easier. Some would be easier to merge/less subject to debate than others. Also, one PRs may turn into a hell of fixups for you.

I'd go with 3. Feel free to transmute the issues into PRs. I tend to do this though http://issue2pr.herokuapp.com/.

Therzok added a commit that referenced this issue Dec 2, 2014
Therzok added a commit that referenced this issue Dec 2, 2014
@nulltoken nulltoken added this to the v0.21 milestone Dec 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants