Introduce GlobalSettings.NativeLibraryPath
#992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm. AppVeyor doesn't like the change. Yet. 😉 |
LibGit2Sharp/GlobalSettings.cs
Outdated
There was a problem hiding this comment.
Would there be a way to throw as well if any call to the native library has already been made?
|
@ethomson Strange. AppVeyor is still failing... |
|
Yeah, I'm not sure why the natives aren't loading there yet. Should have been mostly a no-op, I would have thought, but maybe I did something dumb. Investigating. |
ethomson
force-pushed
the
ethomson/custom_nativepath
branch
from
8bdc30c to
d243f20
Compare
added 3 commits
March 13, 2015 21:26
Allow consumers to set the native library path in case they are running in a strange environment that they have little control over where the actual executing assembly lives (but do have some control over the references) and want to point the library to the native location explicitly.
nulltoken
force-pushed
the
ethomson/custom_nativepath
branch
from
d243f20 to
e56c097
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
GlobalSettings.NativeLibraryPathon Windows, that allows consumers to configure the location where native libraries will get loaded.This is advantageous in some environments where you have control over the location of your native libraries, but do not have any control over the location of the executing assembly. An example of such a crazy setup would be an MSBuild task - custom tasks are built (and executed from)
%LOCALAPPDATA%\Temp\<random>.