Skip to content

Conversation

sagmor
Copy link
Contributor

@sagmor sagmor commented Apr 13, 2015

Here I'm proposing two small API changes.
I recently started working with this library and some names felt misleading to me at first. So I presume they might be misleading to others:

First, GTIndex operations are performed with paths but that's not clear from the API so I changed all references like entryWithName: to entryWithPath:

Then on GTBranch, targetCommitAndReturnError: felt strange ¿Is it returning an error or a commit? so I renamed it to targetCommitWithError:

I kept the old methods with a deprecation warning.

⚠️ this PR is based on #452 so merging this will merge that PR too, needed that because XCode 6.3 was released.

@joshaber
Copy link
Member

Those changes sound fine to me. Obviously we'll have to wait on #452 to land first 🍪

@joshaber joshaber self-assigned this Apr 14, 2015
@joshaber
Copy link
Member

joshaber added a commit that referenced this pull request Jun 22, 2015
@joshaber joshaber merged commit c3188a4 into libgit2:master Jun 22, 2015
@sagmor
Copy link
Contributor Author

sagmor commented Jun 22, 2015

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants