Skip to content

Conversation

joshaber
Copy link
Member

@joshaber joshaber commented Jun 4, 2015

The old API was … interesting. This is much more idiomatic.

@mdiep mdiep self-assigned this Jun 4, 2015
/// Look up a reference by name.
///
/// name - The name of the reference to look up. Cannot be nil.
/// error - The error if one occurs. May be NULL.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some day we'll be able to use nonnull and nullable. 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdiep
Copy link
Contributor

mdiep commented Jun 4, 2015

Love this! 💖

mdiep added a commit that referenced this pull request Jun 4, 2015
@mdiep mdiep merged commit d4e18a9 into master Jun 4, 2015
@mdiep mdiep deleted the look-up-ref branch June 4, 2015 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants