-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move go-libp2p-peerstore to p2p/host/peerstore #1667
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactor the peerstore into interface, in-memory implementation, datastore implementation. * Create common test suites to test all implementations against. * Normalise naming: rename AddrMgr => AddrBook everywhere. * Create interface PeerMetadata, with in-memory implementation. * Adjust wait times in time-dependent tests.
* Introduce tests for KeyBook to increase coverage. * Change usages of []peer.ID to IDSlice, which supports sorting. * Restructure AddrBook tests into subtests. * Import aliases.
implement a clean shutdown for the memory address book
optimize allocations in the memory address book
move AddrList to pstoremen, unexport it
remove the addr package
remove all calls to peer.ID.Validate
feat: use a clock interface to better support testing for pstoremem
feat: Use a clock interface in pstoreds as well
vyzo
approved these changes
Aug 9, 2022
We should fix libp2p/go-libp2p-peerstore#203 and libp2p/go-libp2p-peerstore#204 first. Tests are flaky. |
Stebalien
approved these changes
Aug 9, 2022
marten-seemann
force-pushed
the
merge-peerstore
branch
2 times, most recently
from
August 15, 2022 09:11
786beee
to
8db02ca
Compare
marten-seemann
force-pushed
the
merge-peerstore
branch
from
August 15, 2022 09:29
8db02ca
to
ab634d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1556.