forked from Themaister/slang-shaders
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Presets broken due to wrong texture or include paths #369
Comments
chyyran
changed the title
List of shaders broken due to wrong texture or include paths
Presets broken due to wrong texture or include paths
Feb 23, 2023
If you're interested, here is a list of hacks I've implemented to account for variations in preset syntax that RetroArch shouldn't properly handle (to the best of my knowledge) at the moment. |
Thanks, I'll take a look. |
Merged
hizzlekizzle
pushed a commit
that referenced
this issue
Feb 24, 2023
* fix preset parsing issues from #369 * one more preset fixed * fix some malformed preset directives * fix preset lines erroneously ending in semicolons * fix another malformed preset directive * make sure grade and glass at least load properly * comment one more bad path
I think we're all set here. If not, or if you find any other goodies, we can reopen it. Thanks again :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://github.com/SnowflakePowered/librashader/blob/master/BROKEN_SHADERS.md
These were found by
librashader's implementation of the parser/preprocessor is obviously different from RetroArch's implementation but all errors were confirmed to be a result of missing files and not implementation differences in parsing logic. I haven't tested what happens when loading these shaders with RetroArch but if they did load I would guess the output would not be as intended.
The text was updated successfully, but these errors were encountered: