More SDL_rand fixes #10064
Merged
More SDL_rand fixes #10064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slouken
reviewed
Jun 19, 2024
|
What's the use case for SDL_rand_bits()? |
Everything else we don't implement. Like rand_double(). Or rand_Sint64(). Or if someone wants to verify my testing with PractRand. |
slouken
approved these changes
Jun 19, 2024
slouken
reviewed
Jun 19, 2024
|
@slouken The two commits that didn't build happened because those files weren't referenced in the Xcode project (and ctrl-f didn't show them to me) Is that an issue with the project file? Also, I believe this PR is all set. |
|
From @madebr src/dynapi/SDL_dynapi.sym still contains SDL_rand_r and is slightly unsorted around SDL_rand |
|
madebr
reviewed
Jun 19, 2024
madebr
reviewed
Jun 19, 2024
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed SDL_rand() to SDL_rand_bits to avoid confusion with std::rand()
Description
Deliberately removed SDL_rand() to force users to use SDL_rand_n() like they should. Added SDL_rand_bits() for the few who need it.
Existing Issue(s)
I was unable to built the tests on my machine. Please run them.