testevdev: Add some driving sim controllers from Proton issue reports #7598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some devices for which SDL's device classification heuristic is known not to give the ideal result. Add a way to incorporate these into our test data, so that when the heuristic is improved we can detect them as their intended device type, without making the test fail before that has been implemented. Signed-off-by: Simon McVittie <smcv@collabora.com>
Ideally we'd detect these as "joysticks" (or more generally, gaming controllers), but in most cases their evdev flags are indistinguishable from an accelerometer or gyro, so the only way to achieve this would be a table of known devices that doesn't currently exist. One exception is the one that reports a THROTTLE axis and TRIGGER, THUMB buttons, which would be reasonable to detect via the joystick heuristic. Signed-off-by: Simon McVittie <smcv@collabora.com>
smcv
commented
Apr 11, 2023
Comment on lines
+946
to
+950
| .name = "Smarty Co. VRS DirectForce Pro Pedals", | ||
| .bus_type = 0x0003, | ||
| .vendor_id = 0x0483, /* STMicroelectronics */ | ||
| .product_id = 0xa3be, /* VRS DirectForce Pro Pedals */ | ||
| .version = 0x0111, |
There was a problem hiding this comment.
This appears to be https://virtualracingschool.com/dfpro-pedals/, presumably a smaller manufacturer using a ST Microelectronics USB component and borrowing ST Microelectronics' vendor ID - hopefully with permission, but who knows.
smcv
commented
Apr 11, 2023
Comment on lines
+998
to
+1002
| .name = "Leo Bodnar Logitech® G25 Pedals", | ||
| .bus_type = 0x0003, | ||
| .vendor_id = 0x1dd2, /* Leo Bodnar Electronics Ltd */ | ||
| .product_id = 0x100c, | ||
| .version = 0x0110, |
There was a problem hiding this comment.
This appears to be https://www.leobodnar.com/shop/index.php?main_page=product_info&products_id=187, a third-party serial-to-USB adapter to connect Logitech G25 pedals (only) as a separate game controller.
This was referenced Apr 12, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
testevdev: Add the ability to mark a device entry as unimplemented
There are some devices for which SDL's device classification heuristic
is known not to give the ideal result. Add a way to incorporate these
into our test data, so that when the heuristic is improved we can
detect them as their intended device type, without making the test fail
before that has been implemented.
testevdev: Add some driving sim controllers from Proton issue reports
Ideally we'd detect these as "joysticks" (or more generally, gaming
controllers), but in most cases their evdev flags are indistinguishable
from an accelerometer or gyro, so the only way to achieve this would be
a table of known devices that doesn't currently exist.
One exception is the one that reports a THROTTLE axis and TRIGGER, THUMB
buttons, which would be reasonable to detect via the joystick heuristic.
Existing Issue(s)
Related to #7500, #7501. I don't currently have
steam-runtime-input-monitororevemu-describeoutput for the device that issue report describes, so I can't add it here, but it would be good to add that device as well.