@clayui/css update mixins to use the clay-css pattern

[pat270]

The clay-css pattern allows more customization through Sass maps without having to declare a variable name for every property. It also must be backward compatible.

• clay-form-control-variant fix(@clayui/css): Mixins clay-form-control-variant old keys should win over new keys #4002
• clay-select-variant @clayui/css Mixins update clay-select-variant to use clay-css pattern, also deprecated keys should win over new keys #4046
• clay-label-variant fix(@clayui/css): Mixins clay-label-size and clay-label-variant convert to use new (easier to remember) Sass map keys. The old keys will still work and win over new keys. #4070
• clay-loading-animation-variant fix(@clayui/css): Mixins update sheet-footer-btn-block and clay-loading-animation-variant to use clay-css pattern #4171
• clay-nav-variant fix(@clayui/css): Mixins clay-nav-variant convert to use new (easie… #4072
• clay-menubar-vertical-expand feat(@clayui/css): Update clay-menubar-vertical-expand to use the clay-css pattern #3988
• clay-menubar-vertical-variant fix(@clayui/css): Update clay-menubar-vertical-variant to use the clay-css pattern  #3998
• sheet-footer-btn-block fix(@clayui/css): Mixins update sheet-footer-btn-block and clay-loading-animation-variant to use clay-css pattern #4171

[matuzalemsteles]

Hey @pat270 I was thinking a little about it, once we finished it, we could publish a post on clayui.com to add more information about this change, the benefits, what changes, the advantages, how to migrate, examples... what do you think?

[pat270]

@matuzalemsteles This would be good.

[matuzalemsteles]

Hey @pat270 since we have that ready and the last one has been merged, it would be good to write a blog post on clayui.com to explain this change and plans to migrate to mixins users, it would also be good to have an idea of how to remove backward compatibility with variables old ones. In that case it would be to get an idea of when we plan to do this, whether it's the next major version or two new major versions from here.

[pat270]

@matuzalemsteles Sure I can start working on a blog post. Removing backward compatibility is easy, we just need to delete some setters in the mixins. I suppose we can remove in the next major version and supply the backward compatible mixins to whoever needs it. They can be easily overridden. If the markup changes a lot, then we will have a problem.

[matuzalemsteles]

Perfect @pat270! Depending on the complexity this can involve in a codebase migration from Clay users that use themes, for example, we can keep this for one more major version if necessary, I expect that we won't have too many markup changes in the next major version 😅

[github-actions]

This issue has been merged and will be released in DXP at https://issues.liferay.com/browse/LPS-130572