Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@clayui/css Atlas Button variables are using deprecated property names #4176

Closed
pat270 opened this issue Jul 21, 2021 · 1 comment · Fixed by #4177
Closed

@clayui/css Atlas Button variables are using deprecated property names #4176

pat270 opened this issue Jul 21, 2021 · 1 comment · Fixed by #4177
Assignees
Labels
3.x comp: clay-css Issues related to Clay CSS type: bug Issues reporting that Component is not doing what should be done

Comments

@pat270
Copy link
Member

pat270 commented Jul 21, 2021

$btn-primary: map-deep-merge(
(
box-shadow: $c-unset,
hover-bg: $primary-d1,
hover-border-color: transparent,
hover: (
background-image: clay-enable-gradients($primary-d1),
),
focus-bg: $primary-d1,
focus-box-shadow: $c-unset,
focus: (
background-image: clay-enable-gradients($primary-d1),
),
disabled-bg: $primary,
active-bg: $primary-d2,
active-border-color: transparent,
active-focus-box-shadow: $c-unset,
),
$btn-primary
);

Property names like hover-bg, focus-box-shadow are deprecated. We should stay consistent with CSS property names in our Sass map variables.

See #3987 for some work on deprecated property names.

@pat270 pat270 added type: bug Issues reporting that Component is not doing what should be done comp: clay-css Issues related to Clay CSS 3.x labels Jul 21, 2021
@pat270 pat270 self-assigned this Jul 21, 2021
pat270 added a commit to pat270/clay that referenced this issue Jul 21, 2021
…stay as close as possible to the way our CSS is written

fixes liferay#4176
@github-actions
Copy link

This issue has been merged and will be released in DXP at https://issues.liferay.com/browse/LPS-130572

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment