fix(@clayui/core): fixes build bug in applications #5942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we introduced a new API and made it required, this would be a major change because we would have to update all applications that use the component to define the `aria-label`, so the ideal would be to make the API optional. Since we have a warning message, this will notify developers to pay attention to this and configure it according to each use case.
|
Merging this to release because it's affecting the master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we introduced a new API and made it required, this would be a major change because we would have to update all applications that use the component to define the
aria-label, so the ideal would be to make the API optional. Since we have a warning message, this will notify developers to pay attention to this and configure it according to each use case.