Skip to content
This repository was archived by the owner on Dec 5, 2020. It is now read-only.

New themes with FontAwesome don't include FontAwesome #380

@jbalsas

Description

@jbalsas

Creating a new theme with FontAwesome fails to import the font.

Test 1:

  • When generating a new theme for 7.2
  • Given you answer Y to the question about including FontAwesome
  • Then:
    • "fontAwesome": true in the package.json of the created theme
    • ❌ Some code like @import 'liferay-font-awesome/scss/font-awesome' in _custom.scss

Test 2:

  • When you run gulp build on the generated theme
  • Then:
    • ✅ The build folder contains a font folder with the icon fonts which is packaged in the war artifact

Test 3:

  • When you run gulp deploy on the generated theme
  • Then:
    • ❌ You can see fontawesome and glyphicons icons in portal

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions