Skip to content

Conversation

@chybisov
Copy link
Member

@chybisov chybisov commented Oct 31, 2025

Which Jira task is linked to this PR?

LF-16416

Why was it implemented this way?

This PR disables permit usage for tokens whose contract name includes the ₮ character (specifically USD₮0) in the SDK.

Ledger devices currently freeze and crash when signing EIP-712 typed-data permits for this token due to the non-ASCII character in the name field. Since the domain name must match the on-chain token name exactly, we cannot safely normalize or replace the character client-side without breaking signature validation.

Temporary fix:
Fallback to standard approval flow for USD₮0 in the SDK to avoid hardware wallet signing failures.

Impact:
No functional change for non-affected tokens.
Users holding USD₮0 on supported chains will complete approvals via the standard approve transaction instead of permit.

We’ll re-enable permits once Ledger resolves Unicode support in typed-data signing.

Checklist before requesting a review

  • I have performed a self-review and testing of my code.
  • This pull request is focused and addresses a single problem.
  • If this PR modifies the SDK API or adds new features that require documentation, I have updated the documentation in the public-docs repository.

@chybisov chybisov merged commit ad00ad4 into main Oct 31, 2025
2 checks passed
@chybisov chybisov deleted the fix-token-message-signing branch October 31, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants