fix(format): wrap hashes in messages for better display #465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chybisov
requested changes
Jul 21, 2025
effie-ms
reviewed
Jul 22, 2025
| }) | ||
| } | ||
|
|
||
| export function wrapLongWords(text: string): string { |
There was a problem hiding this comment.
with replace should be shorter, unless we have anything against regex here
text.replace(/\S{32,}/g, (word) => {
return `${word.slice(0, 8)}...${word.slice(-4)}`
})
There was a problem hiding this comment.
Oh, I didn't know of that function, yeah that is actually much cleaner
effie-ms
approved these changes
Jul 22, 2025
chybisov
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira task is linked to this PR?
https://lifi.atlassian.net/browse/LF-8638
Why was it implemented this way?
The solution I explored was checking messages for hashes, and wrapping them with middle ellipsis, that way, the full error message is visible, but the hashes don't overflow.
Visual showcase (Screenshots or Videos)
Checklist before requesting a review