Skip to content

Conversation

neoalienson
Copy link

Added new parameter 'method' for blacklisting. Useful in simulating 500 on CORS APIs, where OPTIONS should not be blacklisted. e.g.,
curl -X PUT http://localhost:8080/proxy/[:port]/blacklist -d "regex=.*&status=500&method=POST"

lightbody added a commit that referenced this pull request Nov 8, 2014
@lightbody lightbody merged commit 7b76fb8 into lightbody:master Nov 8, 2014
@jekh
Copy link
Collaborator

jekh commented Nov 10, 2014

I know this has been merged already, but could you add some unit tests for this feature? That will make it easier to verify whether other changes to the blacklist have broken this functionality.

Also, FYI -- when I merged this branch into PR #126, I re-added the blacklistRequests(String pattern, int responseCode) method to ProxyServer. All existing client code that blacklists requests from within a Selenium test uses this method, so it would be a breaking change to modify its signature.

@neoalienson neoalienson deleted the blacklist_with_method branch April 3, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants