Add blockchain monitor publisher to reconcile chain tips #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arik-so
suggested changes
Apr 19, 2022
| @@ -478,6 +478,18 @@ class BlockchainObserver { | |||
| return result | |||
| } | |||
|
|
|||
| public func isMonitoring() async -> Bool { | |||
| return await self.monitoringTracker.startTracking() | |||
There was a problem hiding this comment.
that seems like a very dangerous method if it's called before the monitor is running, seeing how it will prevent it from ever being started.
There was a problem hiding this comment.
will this be better?
public func isMonitoring() async throws -> Bool {
try await preloadMonitor()
return await self.monitoringTracker.startTracking()
}
There was a problem hiding this comment.
nah, just add a method to the monitoring Tracker to indicate whether or not it's tracking
There was a problem hiding this comment.
it will be reliable at the moment simply because it's an actor
arik-so
suggested changes
Apr 19, 2022
| @@ -478,7 +478,8 @@ class BlockchainObserver { | |||
| return result | |||
| } | |||
|
|
|||
| public func isMonitoring() async -> Bool { | |||
| public func isMonitoring() async throws -> Bool { | |||
| try await preloadMonitor() | |||
There was a problem hiding this comment.
sorry, that makes it worse. You don't want a check (basically a getter) to change state
jurvis
force-pushed
the
regtest_monitor_tooling
branch
from
484fbe8 to
e02f22f
Compare
jurvis
force-pushed
the
regtest_monitor_tooling
branch
from
e02f22f to
ff6533a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable using Combine to subscribe to chain updates on an interval instead of Task.sleep