Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose a failure reason in PaymentFailure #2095

Closed
TheBlueMatt opened this issue Mar 10, 2023 · 5 comments · Fixed by #2142
Closed

Expose a failure reason in PaymentFailure #2095

TheBlueMatt opened this issue Mar 10, 2023 · 5 comments · Fixed by #2142
Milestone
0.0.115

Comments

@TheBlueMatt
Copy link
Collaborator

When a payment fails completely, we should at least tell the user if its because the recipient rejected it or if we ran out of attempts.
@TheBlueMatt TheBlueMatt added this to the 0.0.115 milestone Mar 10, 2023
@alecchendev
Copy link
Contributor

I can pick this up! Would this mainly be a simple enum added to Event::PaymentFailed with some doc comments? In which case I can try and open a PR tomorrow

@TheBlueMatt
Copy link
Collaborator Author

I think so yea. I believe one of the cash app developers was already gonna try to pick this up this week.

@alecchendev
Copy link
Contributor

Oh okay all good then 👍

@rloomba
Copy link
Contributor

rloomba commented Mar 29, 2023

hey @alecchendev! feel free to take this ticket

@alecchendev
Copy link
Contributor

Sounds good @rloomba, thanks!

@alecchendev alecchendev mentioned this issue Apr 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.0.115
Development

Successfully merging a pull request may close this issue.

Expose a failure reason in PaymentFailed alecchendev/rust-lightning
3 participants
@TheBlueMatt @rloomba @alecchendev