Add helper function for getting preimage from PaymentPurpose #2768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2768 +/- ##
==========================================
- Coverage 88.64% 88.58% -0.06%
==========================================
Files 115 115
Lines 90257 90262 +5
Branches 90257 90262 +5
==========================================
- Hits 80009 79963 -46
- Misses 7842 7886 +44
- Partials 2406 2413 +7 ☔ View full report in Codecov by Sentry. |
jbesraa
reviewed
Dec 4, 2023
| /// Returns the preimage for this payment, if it is known. | ||
| pub fn preimage(&self) -> Option<PaymentPreimage> { | ||
| match self { | ||
| PaymentPurpose::InvoicePayment { payment_preimage, .. } => *payment_preimage, |
There was a problem hiding this comment.
I know its in the original impl, but out of curiosity,
in which scenarios we wouldnt have the payment_preimage in the traditional invoice?
There was a problem hiding this comment.
When creating an invoice you can just supply the payment hash and have the preimage stored externally to ldk
TheBlueMatt
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.