Skip to content

Conversation

tnull
Copy link
Contributor

@tnull tnull commented Jul 28, 2025

Previously, we introduced a chance dynamically determining the base
branch for the check_commits CI job. Unfortunately it used the base_ref
variable, which is only set for pull_requests, not for pushes. Here, we
hence move check_commits to a dedicated workflow that only is run on
PRs.

@tnull tnull requested a review from TheBlueMatt July 28, 2025 12:53
@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Jul 28, 2025

👋 Thanks for assigning @TheBlueMatt as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@tnull tnull removed the request for review from TheBlueMatt July 28, 2025 12:56
@tnull tnull marked this pull request as draft July 28, 2025 12:56
Previously, we introduced a chance dynamically determining the base
branch for the check_commits CI job. Unfortunately it used the base_ref
variable, which is only set for pull_requests, not for pushes. Here, we
hence move `check_commits` to a dedicated workflow that only is run on
PRs.
@tnull tnull force-pushed the 2025-07-fix-the-fix-0.1 branch from 139b136 to ccb20c7 Compare July 28, 2025 13:10
@tnull tnull changed the title Provide ref fallback value in the check_commits CI (0.1) Move check_commits to a dedicated workflow CI (0.1) Jul 28, 2025
@tnull tnull marked this pull request as ready for review July 28, 2025 13:23
@tnull tnull requested a review from TheBlueMatt July 28, 2025 13:23
@ldk-reviews-bot
Copy link

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

@TheBlueMatt TheBlueMatt merged commit cdc6003 into lightningdevkit:0.1 Jul 28, 2025
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants