Skip to content

Conversation

joostjager
Copy link
Contributor

Required for serializing async payments blinded message paths as part of the ldk-node api.

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Sep 5, 2025

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@joostjager joostjager requested a review from tnull September 5, 2025 09:12
Copy link

codecov bot commented Sep 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.75%. Comparing base (04b9a17) to head (8db8813).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4057      +/-   ##
==========================================
- Coverage   88.77%   88.75%   -0.03%     
==========================================
  Files         176      176              
  Lines      129375   129375              
  Branches   129375   129375              
==========================================
- Hits       114855   114821      -34     
- Misses      11915    11944      +29     
- Partials     2605     2610       +5     
Flag Coverage Δ
fuzzing 22.02% <ø> (ø)
tests 88.58% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough, one nit

@ldk-reviews-bot
Copy link

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

@tnull tnull merged commit 457d2bd into lightningdevkit:main Sep 5, 2025
25 checks passed
@TheBlueMatt
Copy link
Collaborator

Please include context in the commit message so that we know why we did something from looking at git history, not just in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants