Add struct-level logging to OutboundPayments #4082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for assigning @tnull as a reviewer! |
joostjager
force-pushed
the
payment-logging
branch
from
b8558c7 to
cc63fe4
Compare
tnull
approved these changes
Sep 18, 2025
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4082 +/- ##
==========================================
- Coverage 88.60% 88.59% -0.02%
==========================================
Files 176 176
Lines 132086 132070 -16
Branches 132086 132070 -16
==========================================
- Hits 117041 117006 -35
- Misses 12376 12397 +21
+ Partials 2669 2667 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Previously, OutboundPayments methods required borrowed logger arguments since Logger lacked a Clone bound. This prevented logging in all desired places, limiting trace statements for debugging. This change initializes OutboundPayments with a cloned Logger, simplifying method signatures and improving logging flexibility.
joostjager
force-pushed
the
payment-logging
branch
from
cc63fe4 to
5fc6282
Compare
|
Added commit msg |
tnull
approved these changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that because there wasn't a
Clonebound on theLoggerpassed toChannelManager, many of the methods ofOutboundPaymentssaw a borrowedloggerargument added, and still it wasn't possible to log everywhere. In debugging async payments, more trace statements would have been helpful, but they couldn't simply be added.This PR initializes
OutboundPaymentswith aLoggerclone, and consequently simplifies method signatures.The module is also in need of rustfmt, but won't do that now to avoid conflict with async payments.