Add tests for lightning-persister with tokio feature to CI
#4125
Conversation
|
👋 Thanks for assigning @joostjager as a reviewer! |
tnull
force-pushed
the
2025-09-ci-test-persister-tokio
branch
from
6e2f2d5 to
b208298
Compare
.. to indicate its existence
We recently introduced a new `tokio` feature to `lightning-persister`, but never added it to CI which has us never run the tests that depend on it. Here we fix this omission.
tnull
force-pushed
the
2025-09-ci-test-persister-tokio
branch
from
b208298 to
96ad240
Compare
| rustdoc-args = ["--cfg", "docsrs"] | ||
|
|
||
| [features] | ||
| tokio = ["dep:tokio"] |
There was a problem hiding this comment.
I had this initially, but it seems this is implicit already.
There was a problem hiding this comment.
Yeah, although I personally prefer to still make it explicit which improves discoverability. But happy to drop it if you prefer.
| echo -e "\n\nChecking and testing lightning-persister with features" | ||
| cargo test -p lightning-persister --verbose --color always --features tokio | ||
| cargo check -p lightning-persister --verbose --color always --features tokio | ||
| cargo doc -p lightning-persister --document-private-items --features tokio |
There was a problem hiding this comment.
Any reason why doc isn't checked for the Block Sync Clients with features above?
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
|
Good catch this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4125 +/- ##
==========================================
+ Coverage 88.53% 88.55% +0.02%
==========================================
Files 179 179
Lines 134329 134306 -23
Branches 134329 134306 -23
==========================================
+ Hits 118923 118937 +14
+ Misses 12656 12619 -37
Partials 2750 2750
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4 participants
We recently introduced a new
tokiofeature tolightning-persister, but never added it to CI which has us never run the tests that depend on it. Here we fix this omission.