Trivially replace wake_by_ref with wake.
#4141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Waker::wake_by_ref` is allowed to be less efficient than `Waker::wake` and given we have ownership we might as well use the more efficient one.
|
👋 I see @tankyleo was un-assigned. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4141 +/- ##
==========================================
- Coverage 88.66% 88.64% -0.02%
==========================================
Files 180 180
Lines 135148 135230 +82
Branches 135148 135230 +82
==========================================
+ Hits 119829 119880 +51
- Misses 12553 12585 +32
+ Partials 2766 2765 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tnull
approved these changes
Oct 4, 2025
There was a problem hiding this comment.
Simple enough
This is similar to wake(), but may be slightly less efficient in the case where an owned Waker is available. This method should be preferred to calling waker.clone().wake().
https://doc.rust-lang.org/std/task/struct.Waker.html#method.wake_by_ref
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waker::wake_by_refis allowed to be less efficient thanWaker::wakeand given we have ownership we might as well use the more efficient one.