Add UserConfig::reject_inbound_splices #4150
Merged
+88
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for assigning @TheBlueMatt as a reviewer! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4150 +/- ##
==========================================
- Coverage 88.72% 88.71% -0.01%
==========================================
Files 180 180
Lines 135528 135622 +94
Branches 135528 135622 +94
==========================================
+ Hits 120241 120322 +81
- Misses 12517 12532 +15
+ Partials 2770 2768 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wpaulino
force-pushed
the
user-config-reject-inbound-splice
branch
from
669217b to
65289e6
Compare
TheBlueMatt
reviewed
Oct 9, 2025
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
wpaulino
force-pushed
the
user-config-reject-inbound-splice
branch
from
65289e6 to
b618324
Compare
This option allows nodes to reject inbound channel splice requests to ensure backwards compatibility is not broken with LDK versions < 0.2 while a splice is pending. Outbound channel splice requests (via `ChannelManager::splice_channel`, an opt-in API) are still allowed as users should be aware of the backwards compatibility risk prior to using the functionality.
wpaulino
force-pushed
the
user-config-reject-inbound-splice
branch
from
b618324 to
8d31a9b
Compare
TheBlueMatt
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option allows nodes to reject inbound channel splice requests to ensure backwards compatibility is not broken with LDK versions < 0.2 while a splice is pending. Outbound channel splice requests (via
ChannelManager::splice_channel, an opt-in API) are still allowed as users should be aware of the backwards compatibility risk prior to using the functionality.Fixes #4051.