refactor: use strings for GRPC uint64 fields #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
approved these changes
Jul 16, 2021
There was a problem hiding this comment.
tACK! Tried out most features and couldn't find anything not working. LGTM 💯
I ran the proto compilation on my machine. But because I have protoc 3.12.x installed I got quite a large diff. I think we should probably move over to docker for generating the protos and also possibly update the protoc version being used. Going to open a PR for this.
|
Thanks for the feedback and testing. The suggested changes have been made. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a big refactoring to use strings to transmit large numbers via GRPC and big.js for large numeric variables within the application. This resolves issues with JS number overflow.
Since many of the GRPC field types changed from
numbertostring, a large portion of the codebase needed to be updated for it to even compile. The commits are broken down based on the section of the code that was updated. Each commit will not compile on its own except for the last one.There are no functional changes in the app. To test, just navigate around and perform some Loop and Pool actions to confirm that no errors occur.