Skip to content

loop: increase maximum miner fee to reduce swap failures #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2022
Merged

Conversation

jamaljsr
Copy link
Member

@jamaljsr jamaljsr commented Jan 7, 2022

This PR increases the maximum miner fee to mimic the behavior of the loop CLI main.go. The MaxMinerFee value should be set higher in order to reduce the chances of a swap failure when onchain fees increase after the swap is initiated.

Closes #307, closes #303

@jamaljsr jamaljsr requested a review from guggero January 7, 2022 15:57
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, LGTM 🎉

@jamaljsr jamaljsr merged commit 140651a into master Jan 11, 2022
@jamaljsr jamaljsr deleted the miner-fee branch January 11, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Match max miner setting to CLI config in Loop Out loop out stuck in "initiated"
2 participants