deps: Upgrade storybook to v6.x #362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohit-nair
force-pushed
the
rn/storybook-upgrade-v6
branch
from
8e0f792 to
2cddde3
Compare
rohit-nair
force-pushed
the
rn/storybook-upgrade-v6
branch
from
2cddde3 to
55e17d8
Compare
|
Now that #370 is merged, can you rebase this one? |
Ran `npx sb upgrade` to upgrade storybook from v5.3 to v6.5. Answer `Yes` to use webpack5 manager.
Disable feature flag to opt-out of the previous behavior of pinning the Emotion version to v10.
rohit-nair
force-pushed
the
rn/storybook-upgrade-v6
branch
from
55e17d8 to
e2a79ca
Compare
|
Rebased this PR. |
jamaljsr
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2/
[Note: This is a stacked PR on top of #370 . Can't set the base branch to
rohit-nair:rn/react-router-upgradehere, most likely as I'm working off of a fork. There are only 2 commits as part of this PR — 809de8b, 2cddde3.]Upgrading storybook to v6.x to address issue #360 .
Got storybook site to load correctly post upgrade.
npx sb upgradeto upgrade storybook from v5.3 to v6.4.FixFixed by rebasing off of deps: UpgradeUncaught TypeError: Cannot read properties of undefined (reading 'Pop')error. My suspicion is that its due to incompatibility withhistory@4.10.1. May require upgradingreact-routeras well.react-routerto v6 #370 .Attached is the log from the upgrade.