Standalone LiT client development #371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamaljsr
reviewed
May 26, 2022
|
@jamaljsr: review reminder |
This implements a new script (`yarn develop`) that lets developers to do LiT frontend client development without having to setup an `lnd` backend. This script uses the mock responses configured in `sampleData` to resolve API requests. Limitations: * The implementation depends on `sampleData` to be up-to-date as the APIs evolve. * Currently it only supports `GET` requests. Alternatives considered: * Use `REACT_APP_DEV_HOST` to point to a `testnet` public server so as to avoid configuring and running `lnd`. * Set up a webpack devserver to proxy responses to a node server running locally that in-turn reads mock responses configured as `<endpoint>.json` files, ex `GetInfo.json`, and sends it as response.
jamaljsr
force-pushed
the
rn/develop-script
branch
from
8136bb5 to
7bacc8d
Compare
|
I rebased via Github to save you from having to do it manually. Going to merge once these flaky workflows stop failing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a new script (
yarn develop) that lets developers to doLiT frontend client development without having to setup an
lndbackend.This script uses the mock responses configured in
sampleDatato resolve APIrequests.
Limitations:
sampleDatato be up-to-date as the APIsevolve.
GETrequests.Alternatives considered:
REACT_APP_DEV_HOSTto point to atestnetpublic server so as to avoidconfiguring and running
lnd.locally that in-turn reads mock responses configured as
<endpoint>.jsonfiles, ex
GetInfo.json, and sends it as response.