ui+connect: minor connect view styling updates #403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Trying to debug these errors. |
jamaljsr
requested changes
Aug 4, 2022
There was a problem hiding this comment.
tACK LGTM 👍
Funny enough, I also updated the border color in the home-screen PR. It's fine to leave it here though, they will cancel each other out when merged.
To fix that error, you have to add the type definition for lightningRed to the Theme type in emotion-theme.d.ts.
dstrukt
force-pushed
the
connect-updates
branch
from
990b9b4 to
5764752
Compare
|
Can you rebase on master and squash these commits into one? There's no need for 3 commits to modify 4 lines of code. 😁 |
…connect border color
dstrukt
force-pushed
the
connect-updates
branch
from
5764752 to
4ce0b87
Compare
jamaljsr
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The day has arrived, PRs for litd!
Starting small though.
ui+common: adds
lightningRedtheme colorui+connect: switches pink for new red color + updates bottom border color
Before:
After:
