Skip to content

mod: fix linter, bump Pool version, prepare for lnd 0.16, prepare for v0.9.0-alpha release #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 30, 2023
Merged

mod: fix linter, bump Pool version, prepare for lnd 0.16, prepare for v0.9.0-alpha release #518

merged 7 commits into from
Mar 30, 2023

Conversation

guggero
Copy link
Member

@guggero guggero commented Mar 15, 2023

We probably want to get #516 in first, but I thought I'd prepare the master branch with the latest version of Pool in case anyone testing out lnd v0.16.0-beta.rcX runs into the MuSig2 upgrade error.
We'll only tag v0.9.0-alpha once the final version of lnd is out.

@levmi
Copy link
Contributor

levmi commented Mar 15, 2023

I believe that we'll also want to update the Loop client for release in litd. Working with the team to ensure we make that happen on the Loop side.

ellemouton
ellemouton reviewed Mar 16, 2023
View reviewed changes
Copy link
Member

@ellemouton ellemouton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but needs a make protos run :)

@guggero guggero force-pushed the linter-fix branch 2 times, most recently from 506e6b5 to 97b4503 Compare March 17, 2023 17:07
@guggero
Copy link
Member Author

guggero commented Mar 29, 2023

Bumped to final lnd v0.16.0-beta, pool v0.22.0-beta and faraday 0.2.10-alpha.

Ran into a weird linter issue that we had in a different project before and investigated for many hours... Disabled the linter for now.

@guggero guggero requested review from ellemouton and jamaljsr March 29, 2023 16:16
@guggero guggero changed the title mod: fix linter, bump Pool version, prepare for lnd 0.16 mod: fix linter, bump Pool version, prepare for lnd 0.16, prepare for v0.9.0-alpha release Mar 29, 2023
@jamaljsr
Copy link
Member

I'm getting this error when I run make install. I tried in both docker and natively on my machine. I'm using go v1.19 and confirmed I'm on commit 82b038d

# github.com/lightninglabs/loop/loopdb
/Users/jamal/gocode/pkg/mod/github.com/lightninglabs/loop@v0.22.0-beta/loopdb/protocol_version.go:71:43: undefined: swapserverrpc.ProtocolVersion_MUSIG2

jamaljsr
jamaljsr approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@jamaljsr jamaljsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK LGTM 🚀

Just needs a make protos as there are Loop updates.

@guggero
Copy link
Member Author

guggero commented Mar 29, 2023

I'm getting this error when I run make install. I tried in both docker and natively on my machine. I'm using go v1.19 and confirmed I'm on commit 82b038d

# github.com/lightninglabs/loop/loopdb
/Users/jamal/gocode/pkg/mod/github.com/lightninglabs/loop@v0.22.0-beta/loopdb/protocol_version.go:71:43: undefined: swapserverrpc.ProtocolVersion_MUSIG2

Oops, sorry, there was a tag missing in the Loop repo.

guggero added 7 commits March 29, 2023 20:34
@guggero
tools+make: update linter
539868d
@guggero
mod: bump pool to v0.6.2-beta
037fa9a
@guggero
mod+proto+app: bump loop to v0.22.0-beta
df7684c
@guggero
README: prepare for lnd 0.16 release
c858e64
@guggero
mod: make sure correct grpc version is pulled in
a92db4c
@guggero
github: disable linter
27f1fd3 
We run into an issue with the linter that couldn't be fixed yet:

level=error msg="Running error: 1 error occurred:\n\t* can't run linter goanalysis_metalinter: buildir: failed to load package loopdb: could not load export data: no export data for \"github.com/lightninglabs/loop/loopdb\"\n\n"

We disable the linter for now until we find out what the problem is.
@guggero
version: bump to v0.9.0-alpha
50228a8
@guggero
Copy link
Member Author

guggero commented Mar 29, 2023

I pushed a docker image guggero/lightning-terminal:v0.9.0-alpha with the latest state of this PR (50228a8) if anyone wants to test with that.

ellemouton
ellemouton approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@ellemouton ellemouton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 🔥

@guggero guggero merged commit 94eff95 into master Mar 30, 2023
@guggero guggero deleted the linter-fix branch March 30, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamaljsr jamaljsr jamaljsr approved these changes

@ellemouton ellemouton ellemouton approved these changes

@positiveblue positiveblue Awaiting requested review from positiveblue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guggero @levmi @jamaljsr @ellemouton