Skip to content

Add Taproot Assets Protocol subserver #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 16, 2023
Merged

Conversation

guggero
Copy link
Member

@guggero guggero commented May 16, 2023

No description provided.

Copy link
Member

@ellemouton ellemouton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jamaljsr
Copy link
Member

It looks like tapcli isn't created when you run make go-install-cli and also should be copied in the Docker image. It should be added to Dockerfile and dev.Dockerfile

@guggero guggero force-pushed the taproot-assets-subserver branch 2 times, most recently from b83f650 to 0889ce6 Compare May 16, 2023 14:53
positiveblue and others added 6 commits May 16, 2023 16:59
Enable to start litd with taproot asset subserver disabled.
The default mode for the new sub-server is "Disabled"
Add coverage in itests for flows with some subservers disabled (based on
Elle's #537)
By default the taproot assets subserver will start in integrated mode
like the rest of subservers. An execption is if we are running in
"mainnet" where we want it disabled because it is not yet supported.

Users won't be able to start the sub-server in "mainnet" even if they
set the `--taproot-assets-mode=` flag.
@guggero guggero force-pushed the taproot-assets-subserver branch from 0889ce6 to 2295c80 Compare May 16, 2023 15:00
@guggero guggero force-pushed the taproot-assets-subserver branch from 2295c80 to a6a3ab6 Compare May 16, 2023 15:01
Copy link
Contributor

@positiveblue positiveblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@jamaljsr jamaljsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK LGTM 🚀

@guggero guggero merged commit 60fe925 into master May 16, 2023
@guggero guggero deleted the taproot-assets-subserver branch May 16, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants