Skip to content

mod+itest: add test case for initiator having zero balance #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

guggero
Copy link
Member

@guggero guggero commented Jul 15, 2024

Depends on lightninglabs/taproot-assets#1021.

This commit adds a test case for the edge case that previously lead to a panic in the sender of an HTLC if the initiator of a channel didn't have any asset balance in the channel anymore.

@guggero
Copy link
Member Author

guggero commented Jul 15, 2024

CI failures seem to be known GitHub runner issues. Re-running but can probably be ignored.

This commit adds a test case for the edge case that previously lead to a
panic in the sender of an HTLC if the initiator of a channel didn't have
any asset balance in the channel anymore.
@guggero guggero force-pushed the initiator-zero-balance-fix branch from 99fd772 to 3da641a Compare July 16, 2024 18:40
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐋

@Roasbeef Roasbeef merged commit 79fec8a into 0-19-staging Jul 16, 2024
11 of 13 checks passed
@guggero guggero deleted the initiator-zero-balance-fix branch July 17, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants