Skip to content

Conversation

hieblmi
Copy link
Collaborator

@hieblmi hieblmi commented Oct 7, 2025

Fixes a display issue mentioned in #1009 (comment)

Copy link

Summary of Changes

Hello @hieblmi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where the command-line interface for static address loop-in quotes would display an incorrect or zero amount when the initial request did not specify an amount. By introducing a new QuotedAmt field in the quote response, the system can now accurately convey the total value of the selected deposits to the user, improving clarity and user experience for static address transactions.

Highlights

  • New QuotedAmt Field: Introduced a new QuotedAmt field in the InQuoteResponse message to explicitly carry the total amount of selected deposits for static address loop-in requests.
  • Corrected Display Logic: Modified the cmd/loop/quote.go file to correctly display the QuotedAmt when a static address loop-in request has an initial amount of zero, ensuring the user sees the actual deposited amount.
  • Backend Population: The loopd/swapclient_server.go now populates the QuotedAmt field with the selectedAmount when generating an InQuoteResponse.
  • API and Documentation Updates: Updated looprpc/client.proto and looprpc/client.swagger.json to include the new quoted_amt field, ensuring API consistency and up-to-date documentation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes an issue with displaying the quoted amount for static address loop-ins when the amount is derived from deposit outpoints. The changes introduce a QuotedAmt field in the InQuoteResponse to carry the actual quoted amount from the server to the client. The client CLI is updated to use this new field. The implementation looks correct and addresses the issue. I've added one suggestion to refactor a piece of code for better readability and maintainability.

Comment on lines +236 to +242
if req.Amt == 0 {
fmt.Printf(satAmtFmt, "Previously deposited "+
"on-chain:", resp.QuotedAmt)
} else {
fmt.Printf(satAmtFmt, "Previously deposited "+
"on-chain:", req.Amt)
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This block can be simplified to avoid repeating the fmt.Printf call and the string literal. By determining the amount to print first and then calling fmt.Printf once, the code becomes more concise and easier to maintain.

		amt := req.Amt
		if amt == 0 {
			amt = resp.QuotedAmt
		}
		fmt.Printf(satAmtFmt, "Previously deposited on-chain:", amt)

Copy link
Member

@sputn1ck sputn1ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hieblmi hieblmi merged commit 3323bea into lightninglabs:master Oct 7, 2025
4 checks passed
@hieblmi hieblmi deleted the fix-static-quote branch October 7, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants