-
Notifications
You must be signed in to change notification settings - Fork 122
staticaddr: fix static quote #1014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @hieblmi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue where the command-line interface for static address loop-in quotes would display an incorrect or zero amount when the initial request did not specify an amount. By introducing a new Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request fixes an issue with displaying the quoted amount for static address loop-ins when the amount is derived from deposit outpoints. The changes introduce a QuotedAmt
field in the InQuoteResponse
to carry the actual quoted amount from the server to the client. The client CLI is updated to use this new field. The implementation looks correct and addresses the issue. I've added one suggestion to refactor a piece of code for better readability and maintainability.
if req.Amt == 0 { | ||
fmt.Printf(satAmtFmt, "Previously deposited "+ | ||
"on-chain:", resp.QuotedAmt) | ||
} else { | ||
fmt.Printf(satAmtFmt, "Previously deposited "+ | ||
"on-chain:", req.Amt) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This block can be simplified to avoid repeating the fmt.Printf
call and the string literal. By determining the amount to print first and then calling fmt.Printf
once, the code becomes more concise and easier to maintain.
amt := req.Amt
if amt == 0 {
amt = resp.QuotedAmt
}
fmt.Printf(satAmtFmt, "Previously deposited on-chain:", amt)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7b371f4
to
39b3752
Compare
Fixes a display issue mentioned in #1009 (comment)