Skip to content

staticaddr: fix static quote #1014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 7, 2025
Merged

staticaddr: fix static quote #1014

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f840852
looprpc: add quoted amount in InQuoteResponse
hieblmi Oct 7, 2025
68baebf
loopd: return quoted amount in InQuoteResponse
hieblmi Oct 7, 2025
39b3752
cmd: print quoted amount from InQuoteRequst
hieblmi Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion cmd/loop/quote.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,13 @@ func printQuoteInResp(req *looprpc.QuoteRequest,
totalFee := resp.HtlcPublishFeeSat + resp.SwapFeeSat

if req.DepositOutpoints != nil {
fmt.Printf(satAmtFmt, "Previously deposited on-chain:", req.Amt)
if req.Amt == 0 {
fmt.Printf(satAmtFmt, "Previously deposited "+
"on-chain:", resp.QuotedAmt)
} else {
fmt.Printf(satAmtFmt, "Previously deposited "+
"on-chain:", req.Amt)
}
Comment on lines +236 to +242
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This block can be simplified to avoid repeating the fmt.Printf call and the string literal. By determining the amount to print first and then calling fmt.Printf once, the code becomes more concise and easier to maintain.

		amt := req.Amt
		if amt == 0 {
			amt = resp.QuotedAmt
		}
		fmt.Printf(satAmtFmt, "Previously deposited on-chain:", amt)

} else {
fmt.Printf(satAmtFmt, "Send on-chain:", req.Amt)
}
Expand Down
1 change: 1 addition & 0 deletions loopd/swapclient_server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1043,6 +1043,7 @@ func (s *swapClientServer) GetLoopInQuote(ctx context.Context,
HtlcPublishFeeSat: int64(quote.MinerFee),
SwapFeeSat: int64(quote.SwapFee),
ConfTarget: htlcConfTarget,
QuotedAmt: int64(selectedAmount),
}, nil
}

Expand Down
Loading