Skip to content

Unit tests for migration #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 69 commits into from
Aug 4, 2023
Merged

Unit tests for migration #311

merged 69 commits into from
Aug 4, 2023

Conversation

Connoropolous
Copy link
Collaborator

No description provided.

kbonnici and others added 30 commits July 12, 2023 09:51
@kbonnici
install jest
ebb713e
@kbonnici
wip testing exportProjectsData
d32c635
@kbonnici
ignore errors preventing tests from running
241aa1b
@kbonnici
mock whoami
e771d79
@kbonnici
add updateProjectMeta as a positional arg to exportProjectsData
fa79c18
@kbonnici
add tests for exportProjectsData
2b7df95
@kbonnici
add test data
661f87b
@kbonnici
use test data in unit tests
f1aaad0
@kbonnici
move added test data into 2nd getState call
c129570
@kbonnici
add test case for when state.whoami is undefined
b29c059
@kbonnici
add integrityVersion to exported data
e48e35e
@kbonnici
replace integrity version number with placeholder
707d1b2
@kbonnici
ts-ignore AppWebsocket
a907110
@kbonnici
define internalImportProjectsData
a5aa502
@kbonnici
add scaffolding for testing
78f0659
@Connoropolous
figured out problem with jest config through trial and error
4fb86e5
@Connoropolous
clean up ts-ignores
3d43581
@kbonnici
add installProjectApp as functional dependancy
67ea84c
@kbonnici
create sample exported project data
d4d380f
@kbonnici
add assertions to UT
74e0682
@kbonnici
add assertions about what arguments should be passed to functional de…
e323413 
…pendancies
@kbonnici
add assertions about test data
34b0ed0
@kbonnici
remove redundant try-catch logic
42787f2
@kbonnici
change passphrase on 2nd test project
5891173
@kbonnici
add test for invalid json
5367a3f
@kbonnici
extract functional deps for installProjectAppAndImport()
c3deee2
@kbonnici
add unit test for installProjectAppAndImport()
fd874e4
@Connoropolous
Merge branch 'main' into add-jest
cd03226
@kbonnici
move large test data definitions into their own file
93c89b5
@kbonnici
remove now un-needed whoami declaration in test file
1436a90
Connoropolous
Connoropolous commented Aug 2, 2023
View reviewed changes
Connoropolous
Connoropolous commented Aug 3, 2023
View reviewed changes
@Connoropolous
Copy link
Collaborator Author

@kbonnici I added the CI for the new tests in this commit:
293bc4f

@Connoropolous
Copy link
Collaborator Author

@kbonnici maybe the import.ts file is too long now. Can you split it up into multiple files as you see fit?

Connoropolous
Connoropolous commented Aug 3, 2023
View reviewed changes
Connoropolous
Connoropolous commented Aug 3, 2023
View reviewed changes
Copy link
Collaborator Author

@Connoropolous Connoropolous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review. Will add more likely

Connoropolous
Connoropolous commented Aug 4, 2023
View reviewed changes
@kbonnici kbonnici merged commit 18a2b12 into main Aug 4, 2023
@kbonnici kbonnici deleted the add-jest branch August 4, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Connoropolous @kbonnici