Skip to content

add zod schemas to validate migration data parsing logic #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Aug 8, 2023
Merged

add zod schemas to validate migration data parsing logic #314

merged 29 commits into from
Aug 8, 2023

Conversation

kbonnici
Copy link
Contributor

@kbonnici kbonnici commented Aug 4, 2023 •
edited by Connoropolous
Loading

  • @Connoropolous : implement use real INTEGRITY_VERSION number for data export

@kbonnici kbonnici requested a review from Connoropolous August 4, 2023 23:11
@kbonnici kbonnici self-assigned this Aug 4, 2023
Connoropolous
Connoropolous previously requested changes Aug 5, 2023
View reviewed changes
Copy link
Collaborator

@Connoropolous Connoropolous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the zod definitions, awesome.

I am thinking about the possibility to sandbox them in their own npm package in this same project repo, so that we can enable strict mode and reduce the duplication of the types.

kbonnici and others added 23 commits August 7, 2023 11:13
@kbonnici
add zod-models as a new npm package
2342268
@kbonnici
import zod-models in import.ts
6b96762
@kbonnici
add test for valid json but invalid schema
171c48f
@kbonnici
add zod-models to web/package.json
1b18a26
@kbonnici
add clarifying comment to cloneConnection()
3657fb9
@Connoropolous
make unit test function again
70677e4
@Connoropolous
build zod-models first
1e7ba0b
@Connoropolous
rearrange backwards compat strategy
64bfd62
@Connoropolous
try this for fix of projectmeta
0cf6908
@Connoropolous
switch order to that more extensive schema gets caught first
690f858
@kbonnici
update import to zod-models
f11cb0c
@kbonnici
give the unmigrated project data a top priority outcome
0f1ca54
@kbonnici
add tests for cloneProjectMeta() and for cloneConnection()
ad6b384
@Connoropolous
Merge branch 'main' into add-zod
231f4a7
@Connoropolous
fix for #318
5eacbde
@kbonnici
add files for schemas in zod-models
e737a33
@kbonnici
import and re-export all schemas and types in zodModels.ts
f0e2fe6
@kbonnici
add build step for zod-models in CI
dc9d315
@Connoropolous
fix for #310
0472215
@Connoropolous
Merge branch 'add-zod' into bug-fixes-aug-7
c3861ba
@Connoropolous
just testing and code commenting
1e062f7
@Connoropolous
pass presence into PeoplePicker as well
c998f50
@Connoropolous
Merge pull request #319 from lightningrodlabs/bug-fixes-aug-7
80e0dff 
bug fixes
@Connoropolous Connoropolous dismissed their stale review August 7, 2023 23:26

dealth with

@Connoropolous
Copy link
Collaborator

@kbonnici we have to make integrityVersion on the schema optional/versioned for backwards compatibility.

@Connoropolous Connoropolous merged commit adf27d5 into main Aug 8, 2023
@Connoropolous Connoropolous deleted the add-zod branch August 8, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Connoropolous Connoropolous Connoropolous approved these changes

Assignees

@kbonnici kbonnici

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kbonnici @Connoropolous