-
Couldn't load subscription status.
- Fork 279
window: use window as global object #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tests are failing, but I don't understand why. |
|
It looks like the Build Summary: 1/4 steps succeeded; 1 failed (disable with --summary none)
test transitive failure
└─ run test transitive failure
└─ zig test Debug native 1 errors
vendor/jsruntime-lib/src/engines/v8/v8.zig:261:29: error: expected type 'html.window.Window', found 'html.window.Window'
nat_obj_ptr.* = obj;
^~~
src/html/window.zig:9:20: note: struct declared here
pub const Window = struct {
^~~~~~
/home/pierre/wrk/browsercore/src/html/window.zig:9:20: note: struct declared here
pub const Window = struct {
^~~~~~
referenced by:
testExecFn__anon_177852: src/run_tests.zig:57:26
testsAllExecFn: src/run_tests.zig:88:23
remaining reference traces hidden; use '-freference-trace' to see all reference traces
Test ERROR
make: *** [Makefile:90: test] Error 1 |
We have a zig compilation error in test only when using the Window global type. See #184 (comment)
We have a zig compilation error in test only when using the Window global type. See #184 (comment)
8b18428 to
b3f4945
Compare
031f64d to
8e3c58c
Compare
Instead of calling the bultin test functions Indeed, it causes issue with type comparison. See #184 (comment)
8e3c58c to
c7fadeb
Compare
Instead of calling the bultin test functions Indeed, it causes issue with type comparison. See #184 (comment)
c7fadeb to
700bd95
Compare
|
Ok, using direct function for JSRuntime test instead of using The only remaining issue is I had to disable a test unit. Idk what is wrong now... If you have an idea @francisbouvier... |
Instead of calling the bultin test functions Indeed, it causes issue with type comparison. See #184 (comment)
700bd95 to
191e25c
Compare
Instead of calling the bultin test functions Indeed, it causes issue with type comparison. See #184 (comment)
191e25c to
886c9da
Compare
depends on lightpanda-io/zig-js-runtime#209