Skip to content

test.yml: expand the use of upload_failure_logs_if_exists. #2516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 30, 2024
Merged

test.yml: expand the use of upload_failure_logs_if_exists. #2516

merged 2 commits into from
Jul 30, 2024

Conversation

norio-nomura
Copy link
Contributor

This change expands the scope of #2507

  • test-templates.sh: add calling diagnose to CHECKS on restart and user-v2
  • test.yml: use upload_failure_logs_if_exists to "Upgrade test" job

Thanks,

@norio-nomura
test-templates.sh: add calling diagnose to CHECKS onrestart and `…
6366227 
…user-v2`

Signed-off-by: Norio Nomura <norio.nomura@gmail.com>
@norio-nomura
test.yml: use upload_failure_logs_if_exists to "Upgrade test" job
bb724bf 
Signed-off-by: Norio Nomura <norio.nomura@gmail.com>
@norio-nomura norio-nomura marked this pull request as ready for review July 30, 2024 00:12
AkihiroSuda
AkihiroSuda approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda added this to the v0.23.0 milestone Jul 30, 2024
@AkihiroSuda AkihiroSuda added the area/test Tests and CI label Jul 30, 2024
@AkihiroSuda AkihiroSuda merged commit 7814796 into lima-vm:master Jul 30, 2024
27 checks passed
@norio-nomura norio-nomura deleted the ci-extend-upload-failure-logs branch July 30, 2024 23:53
@norio-nomura
Copy link
Contributor Author

Thanks! 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
area/test Tests and CI
Projects
None yet
Milestone
v0.23.0
Development

Successfully merging this pull request may close these issues.
2 participants
@norio-nomura @AkihiroSuda