pkg/portfwd: Remove SO_REUSEPORT
#4160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we’re using a single accepting go routine on the port forwarder’s listener, `SO_REUSEPORT` is unnecessary. Applying this change prevents the port forwarder from binding if the listening port is already listened by another process with `SO_REUSEPORT`, resulting in a "bind: address already in use" error. Previously, if the listening port was listened by another process with `SO_REUSEPORT`, the port forwarder succeeded in binding, but the client’s connection could be handled by another process, leading to port forwarding issues without errors. Signed-off-by: Norio Nomura <norio.nomura@gmail.com>
This also may happen in guest OS on |
norio-nomura
added a commit
to norio-nomura/lima
that referenced
this pull request
Oct 8, 2025
support `socat` as a listener and writer. ```console $ ./hack/test-port-forwarding.pl default [nc|socat] [nc|socat] ``` The `nc` command always sets `SO_REUSEPORT` on the listening TCP port. The `socat` command provides a `reuseport` option that enables `SO_REUSEPORT` on the listening TCP port. Ref: lima-vm#4160 (comment) Signed-off-by: Norio Nomura <norio.nomura@gmail.com>
norio-nomura
added a commit
to norio-nomura/lima
that referenced
this pull request
Oct 8, 2025
support `socat` as a listener and writer. ```console $ ./hack/test-port-forwarding.pl default [nc|socat] [nc|socat] ``` The `nc` command always sets `SO_REUSEPORT` on the listening TCP port. The `socat` command provides a `reuseport` option that enables `SO_REUSEPORT` on the listening TCP port. Ref: lima-vm#4160 (comment) Signed-off-by: Norio Nomura <norio.nomura@gmail.com>
norio-nomura
added a commit
to norio-nomura/lima
that referenced
this pull request
Oct 8, 2025
support `socat` as a listener and writer. ```console $ ./hack/test-port-forwarding.pl default [nc|socat] [nc|socat] ``` The `nc` command always sets `SO_REUSEPORT` on the listening TCP port. The `socat` command provides a `reuseport` option that enables `SO_REUSEPORT` on the listening TCP port. Ref: lima-vm#4160 (comment) Signed-off-by: Norio Nomura <norio.nomura@gmail.com>
norio-nomura
added a commit
to norio-nomura/lima
that referenced
this pull request
Oct 8, 2025
support `socat` as a listener and writer. ```console $ ./hack/test-port-forwarding.pl default [nc|socat] [nc|socat] ``` The `nc` command always sets `SO_REUSEPORT` on the listening TCP port. The `socat` command provides a `reuseport` option that enables `SO_REUSEPORT` on the listening TCP port. Ref: lima-vm#4160 (comment) Signed-off-by: Norio Nomura <norio.nomura@gmail.com>
norio-nomura
added a commit
to norio-nomura/lima
that referenced
this pull request
Oct 9, 2025
support `socat` as a listener and writer. ```console $ ./hack/test-port-forwarding.pl default [nc|socat] [nc|socat] ``` The `nc` command always sets `SO_REUSEPORT` on the listening TCP port. The `socat` command provides a `reuseport` option that enables `SO_REUSEPORT` on the listening TCP port. Ref: lima-vm#4160 (comment) Signed-off-by: Norio Nomura <norio.nomura@gmail.com>
norio-nomura
added a commit
to norio-nomura/lima
that referenced
this pull request
Oct 9, 2025
support `socat` as a listener and writer. ```console $ ./hack/test-port-forwarding.pl default [nc|socat] [nc|socat] ``` The `nc` command always sets `SO_REUSEPORT` on the listening TCP port. The `socat` command provides a `reuseport` option that enables `SO_REUSEPORT` on the listening TCP port. Ref: lima-vm#4160 (comment) Signed-off-by: Norio Nomura <norio.nomura@gmail.com> hack/test-port-forwarding.pl: Add a connection timeout option and relax it from 1 second to 2 seconds. Signed-off-by: Norio Nomura <norio.nomura@gmail.com>
norio-nomura
added a commit
to norio-nomura/lima
that referenced
this pull request
Oct 9, 2025
support `socat` as a listener and writer. ```console $ ./hack/test-port-forwarding.pl default [nc|socat] [nc|socat] ``` The `nc` command always sets `SO_REUSEPORT` on the listening TCP port. The `socat` command provides a `reuseport` option that enables `SO_REUSEPORT` on the listening TCP port. Ref: lima-vm#4160 (comment) Signed-off-by: Norio Nomura <norio.nomura@gmail.com> hack/test-port-forwarding.pl: Add a connection timeout option and relax it from 1 second to 2 seconds. Signed-off-by: Norio Nomura <norio.nomura@gmail.com>
norio-nomura
added a commit
to norio-nomura/lima
that referenced
this pull request
Oct 9, 2025
support `socat` as a listener and writer. ```console $ ./hack/test-port-forwarding.pl default [nc|socat] [nc|socat] ``` The `nc` command always sets `SO_REUSEPORT` on the listening TCP port. The `socat` command provides a `reuseport` option that enables `SO_REUSEPORT` on the listening TCP port. Ref: lima-vm#4160 (comment) Signed-off-by: Norio Nomura <norio.nomura@gmail.com> hack/test-port-forwarding.pl: Add a connection timeout option and relax it from 1 second to 3 seconds. Signed-off-by: Norio Nomura <norio.nomura@gmail.com>
norio-nomura
added a commit
to norio-nomura/lima
that referenced
this pull request
Oct 9, 2025
support `socat` as a listener and writer. ```console $ ./hack/test-port-forwarding.pl default [nc|socat] [nc|socat] ``` The `nc` command always sets `SO_REUSEPORT` on the listening TCP port. The `socat` command provides a `reuseport` option that enables `SO_REUSEPORT` on the listening TCP port. Ref: lima-vm#4160 (comment) Signed-off-by: Norio Nomura <norio.nomura@gmail.com> hack/test-port-forwarding.pl: Add a connection timeout option and relax it from 1 second to 3 seconds. Signed-off-by: Norio Nomura <norio.nomura@gmail.com>
|
Thanks! 🙏🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we’re using a single accepting go routine on the port forwarder’s listener,
SO_REUSEPORTis unnecessary.Applying this change prevents the port forwarder from binding if the listening port is already listened by another process with
SO_REUSEPORT, resulting in a "bind: address already in use" error.Previously, if the listening port was listened by another process with
SO_REUSEPORT, the port forwarder succeeded in binding, but the client’s connection could be handled by another process, leading to port forwarding issues without errors.