- 
                Notifications
    
You must be signed in to change notification settings  - Fork 176
 
chore(chart-deps): update ingress-nginx to version 4.13.1 #2453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on cluster created workloads with some services and all worked. Couldn't find regression ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was a bit to soon with my approval. When I press log-out. It redirects to:
https://auth.caslubbers-1.dev-akamai-apl.net/oauth2/start?rd=https://console.caslubbers-1.dev-akamai-apl.net%2Fapps%2Fadmin
And I see:
default backend - 404
This was on a cluster that was on main and then upgraded to this branch
edit: it keeps redirecting to that page so I cannot log back and I am basically stuck
          
 Tested different approaches to fix this, and added a post-upgrade script to run Helmfile with that one ingress that does not get updated.  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested upgrade on cluster again and worked without issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested again and now it works as expected.
This PR updates the dependency ingress-nginx to version 4.13.1.
It also includes a number of changes, partially as a cleanup and for compatibility:
proxy-busy-buffers-sizewas added to override the default. The value needs to be >=proxy-buffer-sizewhich we have increased.Ingressresource are considered a security risk with ratingCritical(https://kubernetes.github.io/ingress-nginx/user-guide/nginx-configuration/annotations-risk/) and only permitted after setting configuration options to disable checks. It has turned out that existing snippets were either ineffective due to configuration errors, or in case of OAuth2-Proxy no longer necessary.