Skip to content

Conversation

@merll
Copy link
Contributor

@merll merll commented Oct 24, 2025

📌 Summary

This PR enhances the runtime upgrade to also re-deploy namespaces in the pre-upgrade phase. This may be necessary due to applications added in the upgraded version.

🔍 Reviewer Notes

The rather large diff results from consolidating the same functionality from multiple places. Both installation and upgrade scenario have been tested.

🧹 Checklist

  • Code is readable, maintainable, and robust.
  • Unit tests added/updated

Copy link
Contributor

@CasLubbers CasLubbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it maybe better to add this to the regular apply? So that the resources in the k8s values get reconciled? This way when someone accidentally deletes a namespace or another resource it gets re-applied

@merll
Copy link
Contributor Author

merll commented Oct 27, 2025

Is it maybe better to add this to the regular apply? So that the resources in the k8s values get reconciled? This way when someone accidentally deletes a namespace or another resource it gets re-applied

Generally, I would agree that namespaces should be reconciled regularly, but firing up Helmfile, despite filtering, takes relatively long, and we should not do too many of these things unnecessarily. Also, if someone deletes one of the core namespaces, there are a lot of additional problems, such as dependent resources waiting to be terminated, possibly stalling the operator to wait. I would suggest addressing this kind of issue in a separate tool, because it should be a rare condition.

If we rewrite this doing a direct create-or-patch on the KubeAPI, it will be much faster and we could also run it each time. There is a follow-up issue for that: https://track.akamai.com/jira/browse/APL-1223

@merll merll requested a review from CasLubbers October 27, 2025 10:26
@Ani1357 Ani1357 merged commit 1b3e5f8 into main Oct 27, 2025
12 checks passed
@Ani1357 Ani1357 deleted the APL-1222 branch October 27, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants