apps/votes: change wording, order and slug for voting code dashboard … #4517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuzzylogic2000
force-pushed
the
kl-2022-09-wroding
branch
2 times, most recently
from
f11de84
to
5208a2e
Compare
fuzzylogic2000
changed the title
philli-m
force-pushed
the
kl-2022-09-wroding
branch
from
551e614
to
2053edc
Compare
philli-m
reviewed
Sep 28, 2022
| @@ -48,7 +48,7 @@ | |||
| margin: 0; | |||
| padding: 0; | |||
|
|
|||
| > li { | |||
| > * { | |||
There was a problem hiding this comment.
now it targets children but won't overwrite additional styles as it's not a high order selector, checked comp lib and it seems ok
fuzzylogic2000
force-pushed
the
kl-2022-09-wroding
branch
from
2053edc
to
be2823f
Compare
fuzzylogic2000
force-pushed
the
kl-2022-09-wroding
branch
from
be2823f
to
c378f00
Compare
Rineee
reviewed
Sep 28, 2022
| {% for page in token_export_iterator %} | ||
| <li class="u-bottom-divider u-space-between"> | ||
| <div class="" id="id-export-tokens-hint"> | ||
| {% translate " code package no." %} - {{ page }} |
There was a problem hiding this comment.
Do we still want the - here or is that a left over?
There was a problem hiding this comment.
Yes, most likely not, will check the wording and fix!
There was a problem hiding this comment.
@Rineee Because of the renaming after, I added that fix to the last commit. 🤷♀️
Rineee
approved these changes
Sep 28, 2022
fuzzylogic2000
force-pushed
the
kl-2022-09-wroding
branch
from
c378f00
to
cb26fb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…components
A few wording changes and fixes. The styling is mostly there... Maybe @phillimorland could have the first look at that (the third commit).