build(deps): bump actions/checkout from 3 to 4 #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=80&v=4){kind=small}
dependabot
bot
added
the
dependencies
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/github_actions/actions/checkout-4
branch
from
4306e7c to
2aad4da
Compare
cofin
added a commit
that referenced
this pull request
Oct 4, 2025
Phase 5 of performance implementation plan - adapter type conversion caching. Changes across 5 adapters (psqlpy, duckdb, oracledb, bigquery, adbc): - Add per-instance LRU cache (5000 entries) for string conversion - Add character pre-check before regex execution - Override convert_if_detected() to use cached conversion - Define adapter-specific SPECIAL_CHARS sets for pre-checking - ADBC: Preserve dialect parameter, add cache_size parameter Impact: 40-60% improvement on string-heavy workloads Cache scope: Per-instance (no config bleed between adapters) Tests: 39 psqlpy+duckdb + 70 adbc tests passing Related: perf.md Phase 5 (#4 Adapter Caching)
cofin
added a commit
that referenced
this pull request
Oct 5, 2025
BREAKING CHANGE: DatabaseConfig wrapper classes removed ## Summary Eliminates DatabaseConfig wrapper pattern and separates async/sync handler code paths for direct async operations. This combined PR merges the planned PRs #2, #3, and #4 from the litestar-pr83-analysis into a single change. ## Architecture Changes **Deleted**: - `sqlspec/extensions/litestar/config.py` (292 lines) - DatabaseConfig wrapper - `tests/unit/test_extensions/test_litestar/test_config.py` (482 lines) **Created**: - `sqlspec/extensions/litestar/handlers_async.py` (289 lines) - Pure async handlers - `tests/unit/test_extensions/test_litestar/test_handlers_async.py` (290 lines) **Modified**: - `sqlspec/extensions/litestar/handlers.py` → `handlers_sync.py` (renamed) - `sqlspec/extensions/litestar/plugin.py` (completely rewritten, 491 lines) - `sqlspec/extensions/litestar/__init__.py` (updated exports) ## Plugin Now Accepts Core Configs Directly **Before**: ```python from sqlspec.extensions.litestar import SQLSpec, DatabaseConfig asyncpg_config = AsyncpgConfig(pool_config={"dsn": "..."}) db_config = DatabaseConfig(config=asyncpg_config) # Heavy wrapper! plugin = SQLSpec(config=db_config) ``` **After**: ```python from sqlspec import SQLSpec from sqlspec.extensions.litestar import SQLSpec as SQLSpecPlugin asyncpg_config = AsyncpgConfig( pool_config={"dsn": "..."}, extension_config={"litestar": {"commit_mode": "autocommit"}} ) sql = SQLSpec() sql.add_config(asyncpg_config) plugin = SQLSpecPlugin(config=asyncpg_config) # No wrapper! ``` ## Handler Routing Plugin uses `config.is_async` ClassVar to route to appropriate handlers: - **Async configs** → `handlers_async.py` (direct await, zero overhead) - **Sync configs** → `handlers_sync.py` (minimal ensure_async_() wrapping) ## Test Results - mypy: 0 errors across 7 source files - ruff: All checks passed - pytest: 14/14 unit tests passing - Net change: -66 lines (901 additions, 967 deletions) ## Migration Users should update to use extension_config pattern. The old DatabaseConfig wrapper has been removed without deprecation as this PR combines multiple planned changes into one. Fixes performance issues identified in PR #83 analysis.
cofin
added a commit
that referenced
this pull request
Oct 5, 2025
* feat!: refactor Litestar extension. BREAKING CHANGE: DatabaseConfig wrapper classes removed ## Summary Eliminates DatabaseConfig wrapper pattern and separates async/sync handler code paths for direct async operations. This combined PR merges the planned PRs #2, #3, and #4 from the litestar-pr83-analysis into a single change. ## Architecture Changes **Deleted**: - `sqlspec/extensions/litestar/config.py` (292 lines) - DatabaseConfig wrapper - `tests/unit/test_extensions/test_litestar/test_config.py` (482 lines) **Created**: - `sqlspec/extensions/litestar/handlers_async.py` (289 lines) - Pure async handlers - `tests/unit/test_extensions/test_litestar/test_handlers_async.py` (290 lines) **Modified**: - `sqlspec/extensions/litestar/handlers.py` → `handlers_sync.py` (renamed) - `sqlspec/extensions/litestar/plugin.py` (completely rewritten, 491 lines) - `sqlspec/extensions/litestar/__init__.py` (updated exports) ## Plugin Now Accepts Core Configs Directly **Before**: ```python from sqlspec.extensions.litestar import SQLSpec, DatabaseConfig asyncpg_config = AsyncpgConfig(pool_config={"dsn": "..."}) db_config = DatabaseConfig(config=asyncpg_config) # Heavy wrapper! plugin = SQLSpec(config=db_config) ``` **After**: ```python from sqlspec import SQLSpec from sqlspec.extensions.litestar import SQLSpec as SQLSpecPlugin asyncpg_config = AsyncpgConfig( pool_config={"dsn": "..."}, extension_config={"litestar": {"commit_mode": "autocommit"}} ) sql = SQLSpec() sql.add_config(asyncpg_config) plugin = SQLSpecPlugin(config=asyncpg_config) # No wrapper! ``` ## Handler Routing Plugin uses `config.is_async` ClassVar to route to appropriate handlers: - **Async configs** → `handlers_async.py` (direct await, zero overhead) - **Sync configs** → `handlers_sync.py` (minimal ensure_async_() wrapping) ## Test Results - mypy: 0 errors across 7 source files - ruff: All checks passed - pytest: 14/14 unit tests passing - Net change: -66 lines (901 additions, 967 deletions) ## Migration Users should update to use extension_config pattern. The old DatabaseConfig wrapper has been removed without deprecation as this PR combines multiple planned changes into one. Fixes performance issues identified in PR #83 analysis. * fix: updated config * fix: ensure tests use local handlers * fix: cleanup * fix: code quality updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebasing might not happen immediately, so don't worry if this takes some time.
Note: if you make any changes to this PR yourself, they will take precedence over the rebase.
Bumps actions/checkout from 3 to 4.
Release notes
Sourced from actions/checkout's releases.
... (truncated)
Changelog
Sourced from actions/checkout's changelog.
... (truncated)
Commits
b4ffde6Link to release page from what's new section (#1514)8530928Correct link to GitHub Docs (#1511)7cdaf2fUpdate CODEOWNERS to Launch team (#1510)8ade135Prepare 4.1.0 release (#1496)c533a0aAdd support for partial checkout filters (#1396)72f2cecUpdate README.md for V4 (#1452)3df4ab1Release 4.0.0 (#1447)8b5e8b7Support fetching without the --progress option (#1067)97a652bUpdate default runtime to node20 (#1436)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)