Skip to content

5.0.0

Choose a tag to compare

@liucijus liucijus released this 25 Jan 11:20
· 42 commits to master since this release
cb950f5
Replace zipper with singlejar (#1463)

* Replace zipper with singlejar

Remove zipper from common attributes

singlejar is already there and can generate jars with resources

Looking at bazel source code `singlejar` utility is used for:
* [pack_sources](https://github.com/bazelbuild/bazel/blob/455454a56e961affb041a1d4a9214f7f313a05aa/src/main/java/com/google/devtools/build/lib/rules/java/JavaInfoBuildHelper.java#L198)
* [resources_jar](https://github.com/bazelbuild/bazel/blob/master/src/main/java/com/google/devtools/build/lib/rules/java/ResourceJarActionBuilder.java#L123)

Motivation:

* use precompiled binaries ie singlejar comes precompiled via remote_java_tools while zipper is built from sources (at least in remote execution)
* use single tool to accomplish same goal

* Fix //test/jmh:Run__test_jmh_test_jmh_jdk11  by specifying correct jdk version instead of system default