only subtract 50ms from stream queue once #256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theomonnom
reviewed
Sep 19, 2024
| self._last_capture = self._q_size = 0.0 | ||
| # remove 50ms to account for processing time | ||
| # (e.g. using wait_for_playout for very small chunks) | ||
| self._q_size = -0.05 |
There was a problem hiding this comment.
This isn't going to work because it assumes we're always sending data.
What is actually being done is:
capture(10seconds)
waitForPlayout(10seconds-50ms)
sleep(20seconds) # doing smthg else/agent not speaking
capture(10seconds)
waitForPlayout(10seconds-50ms)
The above will only work for the first capture
There was a problem hiding this comment.
is this approach better? subtracting directly from the timeout without removing it from the total tally
nbsp
force-pushed
the
nbsp/audiostream/50ms
branch
from
1da4693 to
b7fdb7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resetting to -0.05 on release also breaks things, so it was left at 0.0.