Skip to content

only subtract 50ms from stream queue once #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 19, 2024
Merged

only subtract 50ms from stream queue once #256

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88cb2df
only subtract 50ms from stream queue once
nbsp Sep 19, 2024
b7fdb7d
remove 50ms from each timeout
nbsp Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions livekit-rtc/livekit/rtc/audio_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,6 @@ async def capture_frame(self, frame: AudioFrame) -> None:
now = time.monotonic()
elapsed = 0.0 if self._last_capture == 0.0 else now - self._last_capture
self._q_size += frame.samples_per_channel / self.sample_rate - elapsed

# remove 50ms to account for processing time (e.g. using wait_for_playour for very small chunks)
self._q_size -= 0.05
self._last_capture = now

if self._join_handle:
Expand All @@ -102,7 +99,11 @@ async def capture_frame(self, frame: AudioFrame) -> None:
if self._join_fut.done():
self._join_fut = self._loop.create_future()

self._join_handle = self._loop.call_later(self._q_size, self._release_waiter)
# remove 50ms to account for processing time
# (e.g. using wait_for_playout for very small chunks)
self._join_handle = self._loop.call_later(
self._q_size - 0.05, self._release_waiter
)

req = proto_ffi.FfiRequest()
req.capture_audio_frame.source_handle = self._ffi_handle.handle
Expand Down
Loading