fix: single quotes and apostrophe

Author: meinradandermatt

spec/clipboard.spec.js

@@ -193,6 +193,15 @@ describe('Clipboard', function () {
     // Replace quotation marks
     // ------------------
 
+    it('do nothting when replaceQuotes is not set', function () {
+      const updatedConfig = cloneDeep(config)
+      updatedConfig.pastedHtmlRules.replaceQuotes = undefined
+
+      updateConfig(updatedConfig)
+      const block = extractSingleBlock('text outside "text inside"')
+      expect(block).toEqual('text outside "text inside"')
+    })
+
     it('replace quotation marks', function () {
       const block = extractSingleBlock('text outside "text inside"')
       expect(block).toEqual('text outside “text inside”')
@@ -223,16 +232,31 @@ describe('Clipboard', function () {
       expect(block).toEqual('text outside “text “inside” „second “inside” text”')
     })
 
+    it('replace apostrophe', function () {
+      const block = extractSingleBlock(`don't`)
+      expect(block).toEqual('don’t')
+    })
+
+    it('replace apostrophe inside quotes', function () {
+      const block = extractSingleBlock(`outside "don't"`)
+      expect(block).toEqual('outside “don’t”')
+    })
+
     it('replace single quotation marks', function () {
-      const blocks = extract('text outside \'text inside\'')
-      expect(blocks).toEqual('text outside ‘text inside’')
+      const block = extractSingleBlock('text outside \'text inside\'')
+      expect(block).toEqual('text outside ‘text inside’')
     })
 
     it('replace nested quotes with single quotes inside nested', function () {
       const block = extractSingleBlock('text outside "text \'inside\' „second inside text“"')
       expect(block).toEqual('text outside “text ‘inside’ “second inside text””')
     })
 
+    it('replace nested quotes with single quotes inside nested', function () {
+      const block = extractSingleBlock(`text outside "text 'inside „second inside text“'"`)
+      expect(block).toEqual('text outside “text ‘inside “second inside text”’”')
+    })
+
     it('replace quotation marks around elements', function () {
       const block = extractSingleBlock('text outside "<b>text inside</b>"')
       expect(block).toEqual('text outside “<strong>text inside</strong>”')

src/clipboard.js

@@ -3,22 +3,13 @@ import $ from 'jquery'
 import config from './config'
 import * as string from './util/string'
 import * as nodeType from './node-type'
+import * as quotes from './quotes'
 
 let allowedElements, requiredAttributes, transformElements, blockLevelElements, replaceQuotes
 let splitIntoBlocks, blacklistedElements
 const whitespaceOnly = /^\s*$/
 const blockPlaceholder = '<!-- BLOCK -->'
 let keepInternalRelativeLinks
-const doubleQuotePairs = [
-  ['«', '»'], // ch german, french
-  ['»', '«'], // danish
-  ['"', '"'], // danish, not specified
-  ['“', '”'], // english US
-  ['”', '”'], // swedish
-  ['“', '“'], // chinese simplified
-  ['„', '“'] // german
-]
-const quotesRegex = /(["'«»„“])(?![^<]*?>)/g
 
 updateConfig(config)
 export function updateConfig (conf) {
@@ -181,67 +172,9 @@ export function cleanWhitespace (str) {
 }
 
 export function replaceAllQuotes (str) {
-  const quotes = getAllQuotes(str)
-  if (quotes && quotes.length > 0) {
-    const replacementQuotes = getReplacementArray(quotes, 0)
-    return replaceExistingQuotes(str, replacementQuotes)
+  if (replaceQuotes.quotes) {
+    return quotes.replaceAllQuotes(str, replaceQuotes)
   }
-  return str
-}
-
-function getReplacementArray (quotes, position) {
-  const quotesArray = []
-  if (quotes.length === 1) {
-    return quotes
-  }
-
-  while (position < quotes.length) {
-    const closingTagPosition = findClosingQuote(quotes, position)
-    let nestedArray = []
 
-    if (closingTagPosition !== position + 1 && closingTagPosition !== -1 && closingTagPosition !== undefined) {
-      const nestedquotes = quotes.slice(position + 1, closingTagPosition)
-      if (nestedquotes) {
-        nestedArray = getReplacementArray(nestedquotes, 0)
-      }
-    }
-    if (closingTagPosition) {
-      position = closingTagPosition + 1
-    }
-    if (closingTagPosition === undefined || closingTagPosition === -1) {
-      quotesArray.push(quotes[position])
-      position++
-    } else {
-      quotesArray.push(...[replaceQuotes.quotes[0], ...nestedArray, replaceQuotes.quotes[1]])
-    }
-  }
-
-  return quotesArray
-}
-
-function findClosingQuote (quotes, position) {
-  const openingQuote = quotes[position]
-  for (let i = position + 1; i < quotes.length; i++) {
-    const isIncluded = getPossibleClosingQuotes(openingQuote).includes(quotes[i])
-    if (isIncluded) {
-      return i
-    }
-  }
-}
-
-function getPossibleClosingQuotes (openingQuote) {
-  return doubleQuotePairs.filter(quotePair => quotePair[0] === openingQuote).map((quotePair) => quotePair[1])
-}
-
-function getAllQuotes (str) {
-  return str.match(quotesRegex)
-}
-
-function replaceExistingQuotes (str, replacementQuotes) {
-  let index = 0
-  return str.replace(quotesRegex, (match) => {
-    const replacement = replacementQuotes[index]
-    index++
-    return replacement
-  })
+  return str
 }

src/config.js

@@ -79,7 +79,8 @@ export default {
 
     replaceQuotes: {
       quotes: ['“', '”'],
-      singleQuotes: ['‘', '’']
+      singleQuotes: ['‘', '’'],
+      apostrophe: '’'
     }
   }
 }

src/quotes.js

@@ -0,0 +1,111 @@
+const doubleQuotePairs = [
+  ['«', '»'], // ch german, french
+  ['»', '«'], // danish
+  ['"', '"'], // danish, not specified
+  ['“', '”'], // english US
+  ['”', '”'], // swedish
+  ['“', '“'], // chinese simplified
+  ['„', '“'] // german
+]
+const singleQuotePairs = [
+  ['‘', '’'], // english UK
+  ['‹', '›'], // ch german, french
+  ['‚', '‘'], // german
+  ['’', '’'], // swedish
+  ['›', '‹'], // danish
+  [`'`, `'`], // danish, not specified
+  [`‘`, `’`] // chinese simplified
+]
+
+const apostrophe = [
+  '’', // german
+  `'` // default
+]
+const quotesRegex = /([‘’‹›‚'«»"“”„])(?![^<]*?>)/g
+let replaceQuotes
+
+export function replaceAllQuotes (str, replaceQuotesRules) {
+  replaceQuotes = replaceQuotesRules
+  const quotes = getAllQuotes(str)
+  if (quotes && quotes.length > 0) {
+    const replacementQuotes = getReplacementArray(quotes, 0)
+    return replaceExistingQuotes(str, replacementQuotes)
+  }
+
+  return str
+}
+
+function getReplacementArray (quotes, position) {
+  const quotesArray = []
+  if (quotes.length === 1) {
+    const replacedQuote = replaceApostrophe(quotes[0])
+    return [replacedQuote]
+  }
+
+  while (position < quotes.length) {
+    const closingTag = findClosingQuote(quotes, position)
+    let nestedArray = []
+
+    if (closingTag !== undefined && closingTag.position !== position + 1 && closingTag.position !== -1) {
+      const nestedquotes = quotes.slice(position + 1, closingTag.position)
+      if (nestedquotes) {
+        nestedArray = getReplacementArray(nestedquotes, 0)
+      }
+    }
+
+    if (closingTag === undefined || closingTag.position === -1) {
+      const replacedQuote = replaceApostrophe(quotes[position])
+      quotesArray.push(replacedQuote)
+      position++
+    } else {
+      position = closingTag.position + 1
+      if (closingTag.type === 'double') {
+        quotesArray.push(...[replaceQuotes.quotes[0], ...nestedArray, replaceQuotes.quotes[1]])
+      }
+      if (closingTag.type === 'single') {
+        quotesArray.push(...[replaceQuotes.singleQuotes[0], ...nestedArray, replaceQuotes.singleQuotes[1]])
+      }
+    }
+  }
+
+  return quotesArray
+}
+
+function findClosingQuote (quotes, position) {
+  const openingQuote = quotes[position]
+  const possibleClosingSingleQuotes = getPossibleClosingQuotes(openingQuote, singleQuotePairs)
+  const possibleClosingDoubleQuotes = getPossibleClosingQuotes(openingQuote, doubleQuotePairs)
+  for (let i = position + 1; i < quotes.length; i++) {
+    if (possibleClosingSingleQuotes.includes(quotes[i])) {
+      return {position: i, type: 'single'}
+    }
+    if (possibleClosingDoubleQuotes.includes(quotes[i])) {
+      return {position: i, type: 'double'}
+    }
+  }
+}
+
+function getPossibleClosingQuotes (openingQuote, pairs) {
+  return pairs.filter(quotePair => quotePair[0] === openingQuote).map((quotePair) => quotePair[1])
+}
+
+function replaceApostrophe (quote) {
+  if (apostrophe.includes(quote)) {
+    return replaceQuotes.apostrophe
+  }
+
+  return quote
+}
+
+function getAllQuotes (str) {
+  return str.match(quotesRegex)
+}
+
+function replaceExistingQuotes (str, replacementQuotes) {
+  let index = 0
+  return str.replace(quotesRegex, (match) => {
+    const replacement = replacementQuotes[index]
+    index++
+    return replacement
+  })
+}