Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MA86 Z headers not working with C++ #15

Closed
cnpetra opened this issue Feb 25, 2020 · 1 comment
Closed

MA86 Z headers not working with C++ #15

cnpetra opened this issue Feb 25, 2020 · 1 comment

Comments

@cnpetra
Copy link
Collaborator

cnpetra commented Feb 25, 2020

MA86 Z headers are not working with C++ when std::complex includes are present.

A temporary dirty-ish fix below.

  1. In the MA86 'include' directory, copy 'hsl_mc69z.h" and "hsl_ma86z.h" to 'hsl_mc69z.hpp" and "hsl_ma86z.hpp"

Edit 'hsl_mc69z.hpp" and "hsl_ma86z.hpp" as in 2, 3, and 4 below.

  1. After #include <complex.h> add these lines
#ifdef __cplusplus
extern "C" {
#endif
  1. replace "complex" with "_Complex" whenever occurs in "double complex" or "complex double"

  2. before the last #endif insert these lines

#ifdef __cplusplus
}
#endif
@cnpetra
Copy link
Collaborator Author

cnpetra commented Apr 7, 2020

became obsolete in some sense. umfpack is used now instead as it turned out that the Kron reduction needs to factorizations of nonsymmetric matrices.

@cnpetra cnpetra closed this as completed Apr 7, 2020
ashermancinelli pushed a commit that referenced this issue Jun 22, 2021
…tor'

Refactorted PIPS implementation for SCOPFLOW. Fixes #15

See merge request exasgd/frameworks/scopflow!1
ashermancinelli pushed a commit that referenced this issue Jun 22, 2021
Shri/scopflow major refactor

Closes #1, #2, #3, #4, #5, #6, #7, #8, #9, #10, #11, #12, #14, #17, #18, and #15

See merge request exasgd/frameworks/scopflow!2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant